[webkit-reviews] review granted: [Bug 182319] Release assertion in Performance::resourceTimingBufferFullTimerFired when the resource timing buffer is shrunk : [Attachment 332788] Fixes the bug

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 182319: Release assertion in
Performance::resourceTimingBufferFullTimerFired when the resource timing buffer
is shrunk
https://bugs.webkit.org/show_bug.cgi?id=182319

Attachment 332788: Fixes the bug

https://bugs.webkit.org/attachment.cgi?id=332788&action=review




--- Comment #8 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 332788
  --> https://bugs.webkit.org/attachment.cgi?id=332788
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=332788&action=review

r=me with suggestion.

> Source/WebCore/page/Performance.cpp:232
> +	   for (auto & entry : m_backupResourceTimingBuffer)

I think we should be able to do this on 2 lines instead of 3 (and potentially
more efficient) using:
backupBuffer.appendVector(m_backupResourceTimingBuffer);
m_backupResourceTimingBuffer.clear();