[webkit-reviews] review denied: [Bug 182326] Should chose the best match during 'route' if there are multiple matches. : [Attachment 332750] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jan 31 11:34:40 PST 2018
Ryosuke Niwa <rniwa at webkit.org> has denied dewei_zhu at apple.com's request for
review:
Bug 182326: Should chose the best match during 'route' if there are multiple
matches.
https://bugs.webkit.org/show_bug.cgi?id=182326
Attachment 332750: Patch
https://bugs.webkit.org/attachment.cgi?id=332750&action=review
--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 332750
--> https://bugs.webkit.org/attachment.cgi?id=332750
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=332750&action=review
r- due to the lack of testing.
> Websites/perf.webkit.org/public/v3/pages/page-router.js:43
> + } else if (hashUrl.startsWith(routeName) &&
hashUrl.charAt(routeName.length) == '/' && bestMatchingRouteName.length <
routeName.length) {
What's hashUrl.charAt(routeName.length) == '/' about?
More information about the webkit-reviews
mailing list