[webkit-reviews] review granted: [Bug 182316] com.apple.WebKit.Storage crashing at com.apple.WebCore: WebCore::SWServerRegistration::removeClientUsingRegistration : [Attachment 332724] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted youenn fablet <youennf at gmail.com>'s
request for review:
Bug 182316: com.apple.WebKit.Storage crashing at com.apple.WebCore:
WebCore::SWServerRegistration::removeClientUsingRegistration
https://bugs.webkit.org/show_bug.cgi?id=182316

Attachment 332724: Patch

https://bugs.webkit.org/attachment.cgi?id=332724&action=review




--- Comment #3 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 332724
  --> https://bugs.webkit.org/attachment.cgi?id=332724
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=332724&action=review

> Source/WebCore/workers/service/server/SWServerRegistration.cpp:184
> +    if (iterator != m_clientsUsingRegistration.end()) {

I would just return early. I don't think we should run handleClientUnload() if
we did not really remove a client. handleClientUnload() relies on
m_clientsUsingRegistration which technically has not changed.