[webkit-reviews] review granted: [Bug 170176] inline-block baseline not computed correctly for vertical-lr : [Attachment 332756] Patch

[bugzilla-daemon at webkit.org]

Manuel Rego Casasnovas <rego at igalia.com> has granted Javier Fernandez
<jfernandez at igalia.com>'s request for review:
Bug 170176: inline-block baseline not computed correctly for vertical-lr
https://bugs.webkit.org/show_bug.cgi?id=170176

Attachment 332756: Patch

https://bugs.webkit.org/attachment.cgi?id=332756&action=review




--- Comment #65 from Manuel Rego Casasnovas <rego at igalia.com> ---
Comment on attachment 332756
  --> https://bugs.webkit.org/attachment.cgi?id=332756
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=332756&action=review

r=me

> Source/WebCore/rendering/RenderBlockFlow.cpp:3064
> +	       if (style.isFlippedLinesWritingMode())
> +		   lastBaseline = logicalHeight() -
lastRootBox()->logicalBottom() +
style.fontMetrics().ascent(lastRootBox()->baselineType());
> +	       else
> +		   lastBaseline = lastRootBox()->logicalTop() +
style.fontMetrics().ascent(lastRootBox()->baselineType());

Nit: Maybe we can write this like:

    lastBaseline = style.isFlippedLinesWritingMode() ? logicalHeight() -
lastRootBox()->logicalBottom() : lastRootBox()->logicalTop();
    lastBaseline += style.fontMetrics().ascent(lastRootBox()->baselineType());