[webkit-reviews] review requested: [Bug 179743] Add support for fetching recent builds in Buildbot 0.9 format in BuildbotSyncer : [Attachment 332744] Updated patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 30 23:12:37 PST 2018


Aakash Jain <aakash_jain at apple.com> has asked  for review:
Bug 179743: Add support for fetching recent builds in Buildbot 0.9 format in
BuildbotSyncer
https://bugs.webkit.org/show_bug.cgi?id=179743

Attachment 332744: Updated patch

https://bugs.webkit.org/attachment.cgi?id=332744&action=review




--- Comment #4 from Aakash Jain <aakash_jain at apple.com> ---
Created attachment 332744

  --> https://bugs.webkit.org/attachment.cgi?id=332744&action=review

Updated patch

> There is no point in manually pushing. Just do:
> return content.builds.map((build) => new BuildbotBuildEntry(this, build));
Done. Thanks for the suggestion.

> What why `+ ` between "builds?" and "limit="? Please concatenate them
instead.
Done

> We need tests for this.

I have tried to break down overall changes into smaller patches. For e.g. this
patch add code to just fetch the recent builds (but does not enable this code
path yet). Final patch in https://bugs.webkit.org/show_bug.cgi?id=175969 start
using all this code and all the test-cases (unit-tests and server-tests) are
updated in that.


More information about the webkit-reviews mailing list