[webkit-reviews] review granted: [Bug 182131] [webkitpy] Config file for apache is copied twice. : [Attachment 332297] fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 30 20:14:37 PST 2018


Daniel Bates <dbates at webkit.org> has granted Basuke Suzuki
<Basuke.Suzuki at sony.com>'s request for review:
Bug 182131: [webkitpy] Config file for apache is copied twice.
https://bugs.webkit.org/show_bug.cgi?id=182131

Attachment 332297: fix

https://bugs.webkit.org/attachment.cgi?id=332297&action=review




--- Comment #2 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 332297
  --> https://bugs.webkit.org/attachment.cgi?id=332297
fix

View in context: https://bugs.webkit.org/attachment.cgi?id=332297&action=review

> Tools/Scripts/webkitpy/layout_tests/servers/apache_http_server.py:95
> +	       '-f', "\"%s\"" % config_file_path,

It would be good to understand why we need to copy the config file to begin
with. This is unrelated to your patch.


More information about the webkit-reviews mailing list