[webkit-reviews] review requested: [Bug 182227] Global objects should be able to use TLCs to allocate from different blocks from each other : [Attachment 332666] new patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has asked  for review:
Bug 182227: Global objects should be able to use TLCs to allocate from
different blocks from each other
https://bugs.webkit.org/show_bug.cgi?id=182227

Attachment 332666: new patch

https://bugs.webkit.org/attachment.cgi?id=332666&action=review




--- Comment #14 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 332666
  --> https://bugs.webkit.org/attachment.cgi?id=332666
new patch

View in context: https://bugs.webkit.org/attachment.cgi?id=332666&action=review

> Source/WebCore/page/SecurityOrigin.h:208
> +    RefPtr<JSC::ThreadLocalCache> threadLocalCache();

Seems odd to have a ThreadLocalCache per SecurityOrigin object. Those objects
are frequently created and we may have a lot of instances actually referring to
the same origin.