[webkit-reviews] review granted: [Bug 181600] FetchResponse should support ConsumeData callback on chunk data is received : [Attachment 332593] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 181600: FetchResponse should support ConsumeData callback on chunk data is
received
https://bugs.webkit.org/show_bug.cgi?id=181600

Attachment 332593: Patch

https://bugs.webkit.org/attachment.cgi?id=332593&action=review




--- Comment #7 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 332593
  --> https://bugs.webkit.org/attachment.cgi?id=332593
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=332593&action=review

> Source/WebCore/Modules/cache/DOMCache.cpp:277
> +	       response.consumeBodyReceivedByChunk([taskHandler =
WTFMove(taskHandler), recordPosition, data = SharedBuffer::create()](auto&&
result) mutable {

I think it makes the code significantly easier to read to have the type of
result here.

>
LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/reso
urces/fetch-event-respond-with-body-loaded-in-chunk-worker.js:6
> +   
event.respondWith(fetch("../../../fetch/api/resources/trickle.py?count=4&delay=
50"));

Does the delay do anything significant here?