[webkit-reviews] review denied: [Bug 182283] [JHBuild] Add gstreamer-vaapi in moduleset : [Attachment 332659] Patch

[bugzilla-daemon at webkit.org]

Carlos Alberto Lopez Perez <clopez at igalia.com> has denied  review:
Bug 182283: [JHBuild] Add gstreamer-vaapi in moduleset
https://bugs.webkit.org/show_bug.cgi?id=182283

Attachment 332659: Patch

https://bugs.webkit.org/attachment.cgi?id=332659&action=review




--- Comment #7 from Carlos Alberto Lopez Perez <clopez at igalia.com> ---
Comment on attachment 332659
  --> https://bugs.webkit.org/attachment.cgi?id=332659
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=332659&action=review

> Tools/Scripts/webkitpy/port/gtk.py:120
>      def setup_environ_for_server(self, server_name=None):
>	   environment = super(GtkPort,
self).setup_environ_for_server(server_name)
> +	   # Make sure va-api support gets disabled because it's incompatible
with Mesa's softGL driver.
> +	   environment['LIBVA_DRIVER_NAME'] = "null"

I think this is the wrong place to set this environment variable.
Because we should only do that when the driver is either xvfb or weston (which
are the ones using mesa software render). 
The right place would be this one:
https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/port/gtk.py?rev=22
7427#L132