[webkit-reviews] review denied: [Bug 182286] [WPE] Update jhbuild dependencies : [Attachment 332649] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 30 06:14:15 PST 2018


Michael Catanzaro <mcatanzaro at igalia.com> has denied Charlie Turner
<cturner at igalia.com>'s request for review:
Bug 182286: [WPE] Update jhbuild dependencies
https://bugs.webkit.org/show_bug.cgi?id=182286

Attachment 332649: Patch

https://bugs.webkit.org/attachment.cgi?id=332649&action=review




--- Comment #3 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 332649
  --> https://bugs.webkit.org/attachment.cgi?id=332649
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=332649&action=review

> Tools/wpe/jhbuild.modules:61
> +    <branch module="/pub/GNOME/sources/glib/2.54/glib-2.54.3.tar.xz"
version="2.54.3"

This will break RunLoop, see https://bugzilla.gnome.org/show_bug.cgi?id=761102.
It looks OK if you add the patch for this.


More information about the webkit-reviews mailing list