[webkit-reviews] review granted: [Bug 177007] [Win] Warning fix. : [Attachment 332642] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 30 02:57:41 PST 2018


Yusuke Suzuki <utatane.tea at gmail.com> has granted Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 177007: [Win] Warning fix.
https://bugs.webkit.org/show_bug.cgi?id=177007

Attachment 332642: Patch

https://bugs.webkit.org/attachment.cgi?id=332642&action=review




--- Comment #5 from Yusuke Suzuki <utatane.tea at gmail.com> ---
Comment on attachment 332642
  --> https://bugs.webkit.org/attachment.cgi?id=332642
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=332642&action=review

> Source/WTF/wtf/ThreadingWin.cpp:270
> +#define InvalidThread ((Thread*)(UINT_PTR)(0xbbadbeef))

I like `uintptr_t` even in Windows only code. And we prefer C++ casts.
`reinterpret_cast<Thread*>(static_cast<uintptr_t>(0xbbadbeef))` is better.


More information about the webkit-reviews mailing list