[webkit-reviews] review requested: [Bug 182274] [CMake] Make WTF headers copies : [Attachment 332623] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jan 29 20:50:13 PST 2018
Don Olmstead <don.olmstead at sony.com> has asked for review:
Bug 182274: [CMake] Make WTF headers copies
https://bugs.webkit.org/show_bug.cgi?id=182274
Attachment 332623: Patch
https://bugs.webkit.org/attachment.cgi?id=332623&action=review
--- Comment #4 from Don Olmstead <don.olmstead at sony.com> ---
Comment on attachment 332623
--> https://bugs.webkit.org/attachment.cgi?id=332623
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=332623&action=review
So this adds all header files explicitly to the forwarding headers and copies
all of them across all CMake ports.
> Source/WTF/wtf/CMakeLists.txt:246
> + WindowsExtras.h
All files within the root of Source/WTF/wtf are added into this WTF_HEADERS
value.
There is another bug, https://bugs.webkit.org/show_bug.cgi?id=182275, where
some of these should really be moved into platform specific directories and
included explicitly.
> Source/WebDriver/CMakeLists.txt:6
> + "${FORWARDING_HEADERS_DIR}"
In here and in gtest the FORWARDING_HEADERS_DIR is added explicitly.
I'm not happy about this but currently WTF has both #include <> and #include ""
within its headers. Adding the FORWARDING_HEADERS_DIR within the
WTF_INCLUDE_DIRECTORIES would possibly result in some ambiguous includes. So
I'm trying to avoid it. Not sure if there's another way in CMake to add a
dependent include path that only affects dependent projects.
The real fix is to just flatten WTF but this is really a first step towards
that.
More information about the webkit-reviews
mailing list