[webkit-reviews] review granted: [Bug 182259] Clean up API after bugs 178240 and 176474 : [Attachment 332589] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 29 15:51:42 PST 2018


mitz at webkit.org has granted Alex Christensen <achristensen at apple.com>'s request
for review:
Bug 182259: Clean up API after bugs 178240 and 176474
https://bugs.webkit.org/show_bug.cgi?id=182259

Attachment 332589: Patch

https://bugs.webkit.org/attachment.cgi?id=332589&action=review




--- Comment #5 from mitz at webkit.org ---
Comment on attachment 332589
  --> https://bugs.webkit.org/attachment.cgi?id=332589
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=332589&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:588
> +    EXPECT_EQ(static_cast<NSUInteger>([[change
objectForKey:NSKeyValueChangeNewKey] integerValue]), _WKRectEdgeLeft |
_WKRectEdgeRight);

Why not just do unsignedIntegerValue?


More information about the webkit-reviews mailing list