[webkit-reviews] review granted: [Bug 182193] Cache API should make sure to resolve caches.open promises in the same order as called : [Attachment 332580] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted youenn fablet <youennf at gmail.com>'s
request for review:
Bug 182193: Cache API should make sure to resolve caches.open promises in the
same order as called
https://bugs.webkit.org/show_bug.cgi?id=182193

Attachment 332580: Patch

https://bugs.webkit.org/attachment.cgi?id=332580&action=review




--- Comment #10 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 332580
  --> https://bugs.webkit.org/attachment.cgi?id=332580
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=332580&action=review

> Source/WebKit/NetworkProcess/cache/CacheStorageEngineCaches.cpp:211
> +	       ASSERT(!error);

Why this assertion? If I have 2 clear requests in
m_pendingWritingCachesToDiskCallbacks, then presumably, the second one will be
resolved with an error once the first request is processed, right?