[webkit-reviews] review granted: [Bug 182206] Don't commit the scrolling tree if layout is dirty : [Attachment 332448] Patch

[bugzilla-daemon at webkit.org]

Frédéric Wang (:fredw) <fred.wang at free.fr> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 182206: Don't commit the scrolling tree if layout is dirty
https://bugs.webkit.org/show_bug.cgi?id=182206

Attachment 332448: Patch

https://bugs.webkit.org/attachment.cgi?id=332448&action=review




--- Comment #2 from Frédéric Wang (:fredw) <fred.wang at free.fr> ---
Comment on attachment 332448
  --> https://bugs.webkit.org/attachment.cgi?id=332448
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=332448&action=review

> Source/WebCore/ChangeLog:9
> +	   timer can fire when the layout timer is still pending, and the
scrolling tree commit itself doens't

nit: doesn't

> Source/WebCore/page/FrameView.cpp:2857
> +    for (Frame* child = frame().tree().firstRenderedChild(); child; child =
child->tree().traverseNextRendered(m_frame.ptr())) {

nit: I think you can use auto* here