[webkit-reviews] review granted: [Bug 182211] [WebAuthN] Add a feature flag : [Attachment 332460] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Jiewen Tan
<jiewen_tan at apple.com>'s request for review:
Bug 182211: [WebAuthN] Add a feature flag
https://bugs.webkit.org/show_bug.cgi?id=182211

Attachment 332460: Patch

https://bugs.webkit.org/attachment.cgi?id=332460&action=review




--- Comment #3 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 332460
  --> https://bugs.webkit.org/attachment.cgi?id=332460
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=332460&action=review

Please revise the title to reflect that you are adding a COMPILE TIME feature
flag, since we already had a runtime flag for enabling/disabling this
experimental feature.

> Source/JavaScriptCore/ChangeLog:3
> +	   [WebAuthN] Add a feature flag

Add a compile-time feature flag

> Source/WebCore/ChangeLog:9
> +	   Add a feature flag for WebAuthN as most of the functionalities are
platform

"Add a compile-time feature flag"

"most of the functionality is platform dependent"