[webkit-reviews] review granted: [Bug 182220] Make MarkedBlock::Footer bigger : [Attachment 332487] the patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jan 28 08:56:12 PST 2018


JF Bastien <jfbastien at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 182220: Make MarkedBlock::Footer bigger
https://bugs.webkit.org/show_bug.cgi?id=182220

Attachment 332487: the patch

https://bugs.webkit.org/attachment.cgi?id=332487&action=review




--- Comment #7 from JF Bastien <jfbastien at apple.com> ---
Comment on attachment 332487
  --> https://bugs.webkit.org/attachment.cgi?id=332487
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=332487&action=review

r=me since this mostly moves stuff around.

> Source/JavaScriptCore/heap/MarkedBlockInlines.h:148
>	   MarkedBlock::Handle* fencedThis = fenceBefore.consume(this);

So these are the only things that can change, and none below need to be
consumed? I'm guessing you thought about it, but worth asking anyways.


More information about the webkit-reviews mailing list