[webkit-reviews] review granted: [Bug 182204] Don't retain focus for input peripheral views : [Attachment 332443] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 26 17:58:54 PST 2018


Tim Horton <thorton at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 182204: Don't retain focus for input peripheral views
https://bugs.webkit.org/show_bug.cgi?id=182204

Attachment 332443: Patch

https://bugs.webkit.org/attachment.cgi?id=332443&action=review




--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 332443
  --> https://bugs.webkit.org/attachment.cgi?id=332443
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=332443&action=review

> Source/WebKit/ChangeLog:10
> +	   focus to be retains on these views anyways, as they don't have
keyboard input, but this

s/retains/retained/

> LayoutTests/fast/forms/ios/ipad/unfocus-inside-fixed-hittest.html:79
> +	       document.getElementById('result').textContent = 'PASS: hit
testing found #target after select interaction';

Doesn’t this change the test result?


More information about the webkit-reviews mailing list