[webkit-reviews] review denied: [Bug 177202] [WinCairo] Fix forwarding header conflict of wincairo webkit : [Attachment 332420] PATCH

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 26 16:31:45 PST 2018


Alex Christensen <achristensen at apple.com> has denied Basuke Suzuki
<Basuke.Suzuki at sony.com>'s request for review:
Bug 177202: [WinCairo] Fix forwarding header conflict of wincairo webkit
https://bugs.webkit.org/show_bug.cgi?id=177202

Attachment 332420: PATCH

https://bugs.webkit.org/attachment.cgi?id=332420&action=review




--- Comment #8 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 332420
  --> https://bugs.webkit.org/attachment.cgi?id=332420
PATCH

View in context: https://bugs.webkit.org/attachment.cgi?id=332420&action=review

> Source/WebKit/PlatformWin.cmake:89
> +    "${WEBKIT_DIR}/UIProcess/WebCoreSupport/curl"

This should go in PlatformWinCairo.cmake.

> Source/WebKit/PlatformWin.cmake:164
> +set(WIN32 0)
> +WEBKIT_CREATE_FORWARDING_HEADERS(WebKit DIRECTORIES
${WebKit_FORWARDING_HEADERS_DIRECTORIES})
> +set(WIN32 1)

This is no good.


More information about the webkit-reviews mailing list