[webkit-reviews] review granted: [Bug 182185] REGRESSiON (r226492): Crash under Element::absoluteEventBounds() on a SVGPathElement which has not been laid out yet : [Attachment 332415] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 26 14:13:04 PST 2018


zalan <zalan at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 182185: REGRESSiON (r226492): Crash under Element::absoluteEventBounds() on
a SVGPathElement which has not been laid out yet
https://bugs.webkit.org/show_bug.cgi?id=182185

Attachment 332415: Patch

https://bugs.webkit.org/attachment.cgi?id=332415&action=review




--- Comment #4 from zalan <zalan at apple.com> ---
Comment on attachment 332415
  --> https://bugs.webkit.org/attachment.cgi?id=332415
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=332415&action=review

> Source/WebCore/svg/SVGPathElement.cpp:424
> +    if (!renderer || !renderer->hasPath())
> +	   return { };

Please add a FIXME here that it's an invalid state.


More information about the webkit-reviews mailing list