[webkit-reviews] review granted: [Bug 182180] We should only append ParserArenaDeletable pointers to ParserArena::m_deletableObjects. : [Attachment 332401] proposed patch.

[bugzilla-daemon at webkit.org]

Michael Saboff <msaboff at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 182180: We should only append ParserArenaDeletable pointers to
ParserArena::m_deletableObjects.
https://bugs.webkit.org/show_bug.cgi?id=182180

Attachment 332401: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=332401&action=review




--- Comment #2 from Michael Saboff <msaboff at apple.com> ---
Comment on attachment 332401
  --> https://bugs.webkit.org/attachment.cgi?id=332401
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=332401&action=review

r=me

> Source/JavaScriptCore/parser/Nodes.h:1698
> +	   // ScopeNode is never instantiate. The life-cycle of its derived
classes are

Change this to ScopeNode is never *directly instantiated*.