[webkit-reviews] review granted: [Bug 140747] [GTK] Support using long-tap gesture to open context menu : [Attachment 332370] Patch adding long press gesture - V2

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has granted Jan-Michael Brummer
<jan.brummer at tabos.org>'s request for review:
Bug 140747: [GTK] Support using long-tap gesture to open context menu
https://bugs.webkit.org/show_bug.cgi?id=140747

Attachment 332370: Patch adding long press gesture - V2

https://bugs.webkit.org/attachment.cgi?id=332370&action=review




--- Comment #7 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 332370
  --> https://bugs.webkit.org/attachment.cgi?id=332370
Patch adding long press gesture - V2

View in context: https://bugs.webkit.org/attachment.cgi?id=332370&action=review

> Source/WebKit/UIProcess/gtk/GestureController.cpp:89
> +void GestureController::Gesture::simulateMousePress(const GdkEvent *event,
int button_type)

I would call this Click instead of Press since this is Motion + Press +
Release. 

const GdkEvent *event -> const GdkEvent* event
int button_type -> unsigned buttonType (or just button, but don't use
underscore).