[webkit-reviews] review granted: [Bug 182004] [css-multicol] Support percentages in column-gap : [Attachment 332268] Patch

[bugzilla-daemon at webkit.org]

Javier Fernandez <jfernandez at igalia.com> has granted Manuel Rego Casasnovas
<rego at igalia.com>'s request for review:
Bug 182004: [css-multicol] Support percentages in column-gap
https://bugs.webkit.org/show_bug.cgi?id=182004

Attachment 332268: Patch

https://bugs.webkit.org/attachment.cgi?id=332268&action=review




--- Comment #7 from Javier Fernandez <jfernandez at igalia.com> ---
Comment on attachment 332268
  --> https://bugs.webkit.org/attachment.cgi?id=332268
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=332268&action=review

> Source/WebCore/css/StyleBuilderConverter.h:1545
> +    auto& primitiveValue = downcast<CSSPrimitiveValue>(value);

What about using a ternary conditional statement here ? We would avoid
declaring the primitiveValue variable, which is used just once. 

return downcast<CSSPrimitiveValue>(value).valueID() == CSSValueNormal ? 
GapLength() : GapLength(convertLength(styleResolver, value));