[webkit-reviews] review granted: [Bug 182083] REGRESSION(r217236): [iOS] PDFDocumentImage does not update its cached ImageBuffer if it has a sub-rectangle of the image : [Attachment 332331] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 182083: REGRESSION(r217236): [iOS] PDFDocumentImage does not update its
cached ImageBuffer if it has a sub-rectangle of the image
https://bugs.webkit.org/show_bug.cgi?id=182083

Attachment 332331: Patch

https://bugs.webkit.org/attachment.cgi?id=332331&action=review




--- Comment #14 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 332331
  --> https://bugs.webkit.org/attachment.cgi?id=332331
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=332331&action=review

> Source/WebCore/ChangeLog:10
> +	   Revert the change r217236 back and fix the issue of throwing the
cached

"throwing"? Do you mean throwing out?

> Source/WebCore/platform/graphics/cg/PDFDocumentImage.cpp:122
> +    // movedCachedImageRect has to inlcude the dirty rectangle.

inlcude -> include