[webkit-reviews] review granted: [Bug 182152] REGRESSION (r221899): Web Content process hangs when webpage tries to make a new window if the WKWebView doesn’t have a UI delegate : [Attachment 332335] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 182152: REGRESSION (r221899): Web Content process hangs when webpage tries
to make a new window if the WKWebView doesn’t have a UI delegate
https://bugs.webkit.org/show_bug.cgi?id=182152

Attachment 332335: Patch

https://bugs.webkit.org/attachment.cgi?id=332335&action=review




--- Comment #2 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 332335
  --> https://bugs.webkit.org/attachment.cgi?id=332335
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=332335&action=review

r=me

> Tools/TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:100
> +    TestWebKitAPI::Util::run(&done);

While it might not matter right now, I think you should be setting `done =
false` in here so this Util::run really waits for your done condition and not
an earlier test's done condition.