[webkit-reviews] review granted: [Bug 181204] [WK1] Layout Test fast/events/beforeunload-dom-manipulation-crash.html is crashing : [Attachment 332298] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 181204: [WK1] Layout Test
fast/events/beforeunload-dom-manipulation-crash.html is crashing
https://bugs.webkit.org/show_bug.cgi?id=181204

Attachment 332298: Patch

https://bugs.webkit.org/attachment.cgi?id=332298&action=review




--- Comment #15 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 332298
  --> https://bugs.webkit.org/attachment.cgi?id=332298
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=332298&action=review

r=me with the new release assertions.

> Source/WebCore/loader/FrameLoader.cpp:1674
>      ASSERT(!m_frame.document() || m_frame.document()->pageCacheState() !=
Document::InPageCache);

Add RELEASE_ASSERT(ScriptDisallowedScope::InMainThread::isScriptAllowed()) here
and FrameLoader::frameDetached().