[webkit-reviews] review granted: [Bug 182064] We should only zero out Wasm Memory virtual pages if they've been modified by the current process : [Attachment 332314] patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Saam Barati <sbarati at apple.com>'s
request for review:
Bug 182064: We should only zero out Wasm Memory virtual pages if they've been
modified by the current process
https://bugs.webkit.org/show_bug.cgi?id=182064

Attachment 332314: patch

https://bugs.webkit.org/attachment.cgi?id=332314&action=review




--- Comment #30 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 332314
  --> https://bugs.webkit.org/attachment.cgi?id=332314
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=332314&action=review

r=me

mac-debug bot looks angry. You should check it before landing.

> Source/WTF/wtf/ZeroFillPages.cpp:45
> +    size_t systemPageSize = pageSize();

I like to write this as "size_t pageSize = WTF::pageSize();". Otherwise, it
reads like you made a subtle change to the value when you transformed it from
"page size" to "system page size".