[webkit-reviews] review granted: [Bug 182083] REGRESSION(r217236): [iOS] PDFDocumentImage does not update its cached ImageBuffer if it has a sub-rectangle of the image : [Attachment 332276] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 182083: REGRESSION(r217236): [iOS] PDFDocumentImage does not update its
cached ImageBuffer if it has a sub-rectangle of the image
https://bugs.webkit.org/show_bug.cgi?id=182083

Attachment 332276: Patch

https://bugs.webkit.org/attachment.cgi?id=332276&action=review




--- Comment #11 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 332276
  --> https://bugs.webkit.org/attachment.cgi?id=332276
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=332276&action=review

> Source/WebCore/platform/graphics/cg/PDFDocumentImage.cpp:116
> +    if (dstRect != m_cachedImageRect &&
!m_cachedImageRect.contains(context.clipBounds()))

Are m_cachedImageRect and context.clipBounds() really in the same coordinate
system?

> Source/WebCore/platform/graphics/cg/PDFDocumentImage.cpp:207
> +    // Clipped option is for testing only. Force recaching the PDF with each
draw.

Maybe re-caching.

If the testing-only comment is accurate, the option should have "ForTesting" in
the name.