[webkit-reviews] review granted: [Bug 180818] Line clamp implementation : [Attachment 332200] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Dave Hyatt <hyatt at apple.com>'s
request for review:
Bug 180818: Line clamp implementation
https://bugs.webkit.org/show_bug.cgi?id=180818

Attachment 332200: Patch

https://bugs.webkit.org/attachment.cgi?id=332200&action=review




--- Comment #16 from Dean Jackson <dino at apple.com> ---
Comment on attachment 332200
  --> https://bugs.webkit.org/attachment.cgi?id=332200
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=332200&action=review

How will Mail toggle the setting? Is it already exposed as a WebPreference?

> Source/WebCore/rendering/RenderBlockFlow.cpp:3238
> +    // FIXME: Orthogonal writing modes don't work here, but it's not even
clear how they should be behave anyway.

Nit: should be behave

> Source/WebCore/rendering/RenderLinesClampFlow.h:39
> +    void layout() override;

Did you need to do this, since you just call RenderMultiColumnFlow::layout()?

> Source/WebCore/rendering/RenderLinesClampSet.cpp:188
> +

Nit: remove blank line