[webkit-reviews] review granted: [Bug 181400] REGRESSION (r226485): Many new wasm leaks detected by the leaks bot : [Attachment 332176] do it right

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Alexey Proskuryakov
<ap at webkit.org>'s request for review:
Bug 181400: REGRESSION (r226485): Many new wasm leaks detected by the leaks bot
https://bugs.webkit.org/show_bug.cgi?id=181400

Attachment 332176: do it right

https://bugs.webkit.org/attachment.cgi?id=332176&action=review




--- Comment #11 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 332176
  --> https://bugs.webkit.org/attachment.cgi?id=332176
do it right

View in context: https://bugs.webkit.org/attachment.cgi?id=332176&action=review

rs=me

> Tools/BuildSlaveSupport/build.webkit.org-config/config.json:133
>		       { "name": "Apple High Sierra (Leaks)", "type":
"TestWebKit1Leaks", "builddir": "highsierra-leaks",
>			 "platform": "mac-highsierra", "configuration":
"release", "architectures": ["x86_64"],
> -			 "additionalArguments": ["--no-retry-failures",
"--no-sample-on-timeout", "--JSC_usePoisoning=0"],
> +			 "additionalArguments": ["--no-retry-failures",
"--no-sample-on-timeout"],
>			 "slavenames": ["bot121"]

Wondering why I don't see the obvious --leaks and -1 on this "TestWebKit1Leaks"
bot. Must be buried somewhere else?

> Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:433
> +    if options.leaks:
> +	   options.additional_env_var.append("JSC_usePoisoning=0")

Is leaks intended to work with WebKit2? If so, you should probably also include
"__XPC_JSC_usePoisoning=0" as well, so that WebContentProcesses would get it.
In practice I think we only run --leaks with -1 right now.