[webkit-reviews] review granted: [Bug 177298] [WebVR] Add OpenVR to the tree and to the build : [Attachment 331627] Patch

[bugzilla-daemon at webkit.org]

Zan Dobersek <zan at falconsigh.net> has granted Sergio Villar Senin
<svillar at igalia.com>'s request for review:
Bug 177298: [WebVR] Add OpenVR to the tree and to the build
https://bugs.webkit.org/show_bug.cgi?id=177298

Attachment 331627: Patch

https://bugs.webkit.org/attachment.cgi?id=331627&action=review




--- Comment #29 from Zan Dobersek <zan at falconsigh.net> ---
Comment on attachment 331627
  --> https://bugs.webkit.org/attachment.cgi?id=331627
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=331627&action=review

> Source/WTF/wtf/Platform.h:1302
> +#if PLATFORM(GTK) || PLATFORM(WPE)
> +#define USE_OPENVR 1
> +#endif

You don't need the define here, it should be provided through
SET_AND_EXPOSE_TO_BUILD() commands in CMake files.

> ChangeLog:21
> +2018-01-18  Sergio Villar Senin  <svillar at igalia.com>
> +
> +	   [WebVR] Add OpenVR to the tree and to the build
> +	   https://bugs.webkit.org/show_bug.cgi?id=177298
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   * Source/CMakeLists.txt:
> +	   * Source/cmake/OptionsGTK.cmake: Enable USE_OPENVR.
> +	   * Source/cmake/OptionsWPE.cmake: Ditto.
> +
> +2017-09-22  Sergio Villar Senin  <svillar at igalia.com>
> +
> +	   [WebVR] Add OpenVR to the tree and to the build
> +	   https://bugs.webkit.org/show_bug.cgi?id=177298
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   * Source/CMakeLists.txt:
> +	   * WebKit.xcworkspace/contents.xcworkspacedata:
> +

Double entries.