[webkit-reviews] review granted: [Bug 181906] Extend 'ifBuilt' config key to set property based on whether certain repositories are built or not. : [Attachment 331839] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted dewei_zhu at apple.com's request for
review:
Bug 181906: Extend 'ifBuilt' config key to set property based on whether
certain repositories are built or not.
https://bugs.webkit.org/show_bug.cgi?id=181906

Attachment 331839: Patch

https://bugs.webkit.org/attachment.cgi?id=331839&action=review




--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 331839
  --> https://bugs.webkit.org/attachment.cgi?id=331839
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=331839&action=review

> Websites/perf.webkit.org/ChangeLog:9
> +	   'ifBuilt' need to conditionally set property based on whether
certain required repositories are built.
> +	   Empty required repository list means no requirement on repository to
set property.

Please explain why we're making this change in the change log.

> Websites/perf.webkit.org/tools/js/buildbot-syncer.js:287
> +		       const meetRepositoryRequirement =
repositoryRequirement.length === 0 || repositoryRequirement.some((repository)
=> commitSet.requiresBuildForRepository(repository));

Use !repositoryRequirement.length instead of === 0.

> Websites/perf.webkit.org/unit-tests/buildbot-syncer-tests.js:1075
> +	   it('should resolve "ifBuilt" with repositories to check', () => {

Should be rephrased as: should set the value for "ifBuilt" if the repository in
the list appears.

> Websites/perf.webkit.org/unit-tests/buildbot-syncer-tests.js:1103
> +	   it('should resolve "ifBuilt" with if only owned commits need build',
() => {

Should re be rephrase as: should not set the value for "ifBuilt" if owned
commits of a repository not in the list appears.