[webkit-reviews] review granted: [Bug 181677] [css-grid] Spanning Grid item has too much space at the bottom / is too high : [Attachment 331909] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jan 22 03:28:54 PST 2018
Javier Fernandez <jfernandez at igalia.com> has granted Manuel Rego Casasnovas
<rego at igalia.com>'s request for review:
Bug 181677: [css-grid] Spanning Grid item has too much space at the bottom / is
too high
https://bugs.webkit.org/show_bug.cgi?id=181677
Attachment 331909: Patch
https://bugs.webkit.org/attachment.cgi?id=331909&action=review
--- Comment #9 from Javier Fernandez <jfernandez at igalia.com> ---
Comment on attachment 331909
--> https://bugs.webkit.org/attachment.cgi?id=331909
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=331909&action=review
> Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp:854
> + - renderGrid()->guttersSize(m_algorithm.grid(), direction,
span.startLine(), span.integerSpan(), availableSpace());
nit: I don't think we need the muti-line format here.
More information about the webkit-reviews
mailing list