[webkit-reviews] review granted: [Bug 181716] Parse calc() in CSS media queries : [Attachment 331872] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Chris Nardi
<christopherncarmel at hotmail.com>'s request for review:
Bug 181716: Parse calc() in CSS media queries
https://bugs.webkit.org/show_bug.cgi?id=181716

Attachment 331872: Patch

https://bugs.webkit.org/attachment.cgi?id=331872&action=review




--- Comment #38 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 331872
  --> https://bugs.webkit.org/attachment.cgi?id=331872
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=331872&action=review

> Source/WebCore/css/MediaQueryExpression.cpp:40
> +static inline bool featureWithValidIdent(const AtomicString& mediaFeature,
const CSSPrimitiveValue* value)

'const CSSPrimitiveValue&' would be better since the value is non-null. RefPtr
has operator* so invoking with 'featureWithValidIdent(m_mediaFeature,
*firstValue)' works.

> Source/WebCore/css/MediaQueryExpression.cpp:58
> +static inline bool featureWithValidDensity(const String& mediaFeature, const
CSSPrimitiveValue* value)

Also here.

> Source/WebCore/css/MediaQueryExpression.cpp:68
> +static inline bool featureWithValidPositiveLength(const String&
mediaFeature, const CSSPrimitiveValue* value)

And here

> Source/WebCore/css/MediaQueryExpression.cpp:100
> +static inline bool featureWithPositiveInteger(const String& mediaFeature,
const CSSPrimitiveValue* value)

And here

> Source/WebCore/css/MediaQueryExpression.cpp:121
> +static inline bool featureWithZeroOrOne(const String& mediaFeature, const
CSSPrimitiveValue* value)

And here