[webkit-reviews] review canceled: [Bug 181825] [GTK] USE_UPOWER causes crashes inside a chroot or on systems with broken dbus/upower : [Attachment 331883] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has canceled Michael Catanzaro
<mcatanzaro at igalia.com>'s request for review:
Bug 181825: [GTK] USE_UPOWER causes crashes inside a chroot or on systems with
broken dbus/upower
https://bugs.webkit.org/show_bug.cgi?id=181825

Attachment 331883: Patch

https://bugs.webkit.org/attachment.cgi?id=331883&action=review




--- Comment #3 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 331883
  --> https://bugs.webkit.org/attachment.cgi?id=331883
Patch

Not ready for review, I missed your warning about up_client_new() also
returning NULL.

And the docs seem to indicate that up_client_new() is synchronous, with a
recommendation to use a method that does not exist if we want to avoid that
behavior. So we're probably going to need to dispatch all the work to a
secondary thread.