[webkit-reviews] review granted: [Bug 181887] DOMCache data sometimes not properly removed when clearing data for a given origin : [Attachment 331798] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Jan 20 00:44:38 PST 2018
youenn fablet <youennf at gmail.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 181887: DOMCache data sometimes not properly removed when clearing data for
a given origin
https://bugs.webkit.org/show_bug.cgi?id=181887
Attachment 331798: Patch
https://bugs.webkit.org/attachment.cgi?id=331798&action=review
--- Comment #5 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 331798
--> https://bugs.webkit.org/attachment.cgi?id=331798
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=331798&action=review
> Source/WebKit/ChangeLog:15
> + generated by cachesRootPath(*folderOrigin) differed from the actual
folder path
Either the salt is different or the stored data is corrupted.
Maybe there was a conflict with cached data stored by a WebKit that was not
partitioning based on ClientOrigin?
We probably should add a version number like we did for service worker paths.
> Source/WebKit/NetworkProcess/cache/CacheStorageEngine.cpp:423
> + m_ioQueue->dispatch([path = folderPath.isolatedCopy(),
taskHandler = WTFMove(taskHandler)] {
Can you add an ASSERT(folderPath == cachesRootPath(*folderOrigin)) ?
More information about the webkit-reviews
mailing list