[webkit-reviews] review granted: [Bug 181876] [Curl] Add timeout support to XMLHttpRequest : [Attachment 331775] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 19 13:22:10 PST 2018


Alex Christensen <achristensen at apple.com> has granted Basuke Suzuki
<Basuke.Suzuki at sony.com>'s request for review:
Bug 181876: [Curl] Add timeout support to XMLHttpRequest
https://bugs.webkit.org/show_bug.cgi?id=181876

Attachment 331775: Patch

https://bugs.webkit.org/attachment.cgi?id=331775&action=review




--- Comment #2 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 331775
  --> https://bugs.webkit.org/attachment.cgi?id=331775
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=331775&action=review

> Source/WebCore/platform/network/ResourceRequestBase.cpp:36
> -#if !USE(SOUP) && (!PLATFORM(MAC) || USE(CFURLCONNECTION))
> +#if !USE(SOUP) && (!PLATFORM(MAC) || USE(CFURLCONNECTION)) && !USE(CURL)

Let's change this to #if PLATFORM(IOS) || USE(CFURLCONNECTION)


More information about the webkit-reviews mailing list