[webkit-reviews] review granted: [Bug 181841] Use promises for basic-gestures.js and 'await' for the corresponding tests : [Attachment 331715] Patch

[bugzilla-daemon at webkit.org]

Megan Gardner <megan_gardner at apple.com> has granted Frédéric Wang (:fredw)
<fred.wang at free.fr>'s request for review:
Bug 181841: Use promises for basic-gestures.js and 'await' for the
corresponding tests
https://bugs.webkit.org/show_bug.cgi?id=181841

Attachment 331715: Patch

https://bugs.webkit.org/attachment.cgi?id=331715&action=review




--- Comment #5 from Megan Gardner <megan_gardner at apple.com> ---
Comment on attachment 331715
  --> https://bugs.webkit.org/attachment.cgi?id=331715
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=331715&action=review

Looks good other than the few formatting things, and the seemingly unneeded
'done' return.

>
LayoutTests/fast/events/touch/ios/long-press-then-drag-left-to-change-selected-
text.html:69
> +		   output += 'FAIL: failed to reduce selection to a single
character by dragging right. Incorrect Selection: ' +	 
document.getSelection().toString();

extraneous spaces after +
Looks like they were there in the original, but should still be removed.

> LayoutTests/fast/events/touch/ios/long-press-then-drag-to-select-text.html:37
> +		   output += 'FAIL: failed to reduce selection to a single
character by dragging down. Incorrect Selection: ' +	
document.getSelection().toString();

extraneous spaces after +

>
LayoutTests/fast/events/touch/ios/long-press-then-drag-up-to-change-selected-te
xt.html:69
> +		   output += 'FAIL: failed to reduce selection to a single
character by dragging down. Incorrect Selection: ' +	
document.getSelection().toString();

Extraneous spaces after +

> LayoutTests/resources/basic-gestures.js:7
> +		       uiController.uiScriptComplete('Done');

Is there a reason that this function now returns 'Done'?