[webkit-reviews] review granted: [Bug 181827] Update XPCSPI.h : [Attachment 331711] proposed patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted Alexey Proskuryakov
<ap at webkit.org>'s request for review:
Bug 181827: Update XPCSPI.h
https://bugs.webkit.org/show_bug.cgi?id=181827

Attachment 331711: proposed patch

https://bugs.webkit.org/attachment.cgi?id=331711&action=review




--- Comment #8 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 331711
  --> https://bugs.webkit.org/attachment.cgi?id=331711
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=331711&action=review

I am assuming this only affects iOS as this patch conditioanlizes on it.

> Source/WTF/wtf/spi/darwin/XPCSPI.h:59
> +#define XPC_NOESCAPE __attribute__((__noescape__))

I am surprised this works on iOS. I guess clang accepts an attribute name with
and without leading and trailing underscores. According to
<https://clang.llvm.org/docs/AttributeReference.html#noescape-clang-noescape>
clang recognizes __attribute__((noescape)).