[webkit-reviews] review granted: [Bug 181786] Don't fetch more than two builds to check duplicity of builds in ReportProcessor : [Attachment 331600] Fixes the bug

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 181786: Don't fetch more than two builds to check duplicity of builds in
ReportProcessor
https://bugs.webkit.org/show_bug.cgi?id=181786

Attachment 331600: Fixes the bug

https://bugs.webkit.org/attachment.cgi?id=331600&action=review




--- Comment #2 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 331600
  --> https://bugs.webkit.org/attachment.cgi?id=331600
Fixes the bug

rs=me.

I'm a bit curious why the maximum limit of 2 builds is hard-coded. Is this
hardware-dependent, and "2" is the most reasonable cap for our machines we're
using to run the perf dashboard? It seems like maybe it should be configurable,
but I'm not familiar with this code at all :P