[webkit-reviews] review denied: [Bug 181801] [Win] Null pointer crash under WebCore::RenderStyle::colorIncludingFallback. : [Attachment 331640] Patch

[bugzilla-daemon at webkit.org]

zalan <zalan at apple.com> has denied Per Arne Vollan <pvollan at apple.com>'s
request for review:
Bug 181801: [Win] Null pointer crash under
WebCore::RenderStyle::colorIncludingFallback.
https://bugs.webkit.org/show_bug.cgi?id=181801

Attachment 331640: Patch

https://bugs.webkit.org/attachment.cgi?id=331640&action=review




--- Comment #4 from zalan <zalan at apple.com> ---
Comment on attachment 331640
  --> https://bugs.webkit.org/attachment.cgi?id=331640
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=331640&action=review

> Source/WebCore/ChangeLog:8
> +	   Check if html element in menu list is connected before getting its
style.

In general, we should be able to access the style even when the element is
detached. Looking at the stacktrace, the real issue here might be that WIN is
too eager to paint a disconnected(?) popup (that should not happen for sure)
and we end up accessing the computed style unexpectedly.