[webkit-reviews] review granted: [Bug 181535] [DFG][FTL] Introduce PhantomNewRegexp and RegExpExecNonGlobalOrSticky : [Attachment 331571] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 181535: [DFG][FTL] Introduce PhantomNewRegexp and
RegExpExecNonGlobalOrSticky
https://bugs.webkit.org/show_bug.cgi?id=181535

Attachment 331571: Patch

https://bugs.webkit.org/attachment.cgi?id=331571&action=review




--- Comment #29 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 331571
  --> https://bugs.webkit.org/attachment.cgi?id=331571
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=331571&action=review

Nice!
r=me

> Source/JavaScriptCore/dfg/DFGNode.h:751
> +	   m_opInfo = 0;

m_opInfo = false?

> Source/JavaScriptCore/dfg/DFGObjectAllocationSinkingPhase.cpp:2326
> +		   OpInfo(1),

OpInfo(true)?

> Source/JavaScriptCore/dfg/DFGStrengthReductionPhase.cpp:717
> +			   OpInfo(0),

OpInfo(false)?

> Source/JavaScriptCore/dfg/DFGStrengthReductionPhase.cpp:854
> +		       OpInfo(0),

OpInfo(false)?