[webkit-reviews] review granted: [Bug 181656] WEBKIT_FRAMEWORK should not modify file-global include directories : [Attachment 331521] Patch

[bugzilla-daemon at webkit.org]

Konstantin Tokarev <annulen at yandex.ru> has granted Michael Catanzaro
<mcatanzaro at igalia.com>'s request for review:
Bug 181656: WEBKIT_FRAMEWORK should not modify file-global include directories
https://bugs.webkit.org/show_bug.cgi?id=181656

Attachment 331521: Patch

https://bugs.webkit.org/attachment.cgi?id=331521&action=review




--- Comment #19 from Konstantin Tokarev <annulen at yandex.ru> ---
Comment on attachment 331521
  --> https://bugs.webkit.org/attachment.cgi?id=331521
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=331521&action=review

> Source/WebCore/CMakeLists.txt:1952
> +target_include_directories(WebCoreTestSupport SYSTEM PUBLIC
${WebCore_SYSTEM_INCLUDE_DIRECTORIES})

Looks great overall, but couldn't this be PRIVATE too?