[webkit-reviews] review denied: [Bug 181739] Update the argument count in DFGByteCodeParser::handleRecursiveCall : [Attachment 331530] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has denied Robin Morisset
<rmorisset at apple.com>'s request for review:
Bug 181739: Update the argument count in DFGByteCodeParser::handleRecursiveCall
https://bugs.webkit.org/show_bug.cgi?id=181739

Attachment 331530: Patch

https://bugs.webkit.org/attachment.cgi?id=331530&action=review




--- Comment #4 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 331530
  --> https://bugs.webkit.org/attachment.cgi?id=331530
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=331530&action=review

> Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1400
> +	       }

This is wrong. Please add a test. The machine argument count is not known at
compile time. We must always update it.