[webkit-reviews] review denied: [Bug 181254] run-webkit-tests fails when there is a curly brace in Xcode build output : [Attachment 331390] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has denied Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 181254: run-webkit-tests fails when there is a curly brace in Xcode build
output
https://bugs.webkit.org/show_bug.cgi?id=181254

Attachment 331390: Patch

https://bugs.webkit.org/attachment.cgi?id=331390&action=review




--- Comment #20 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 331390
  --> https://bugs.webkit.org/attachment.cgi?id=331390
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=331390&action=review

> Tools/Scripts/webkitpy/port/base.py:1430
> +	   if decode_output:
> +	       output = output.encode('utf-8')
>	   _log.debug('Output of %s:\n%s' % (run_script_command, output))

We should only encode |output| for the purpose of calling _log.debug(). That
is, we should not return the encoded data because the caller expects a string
of characters (not a string of bytes).