[webkit-reviews] review granted: [Bug 181637] Add injected bundle SPI to replace subresource URLs when dropping or pasting rich content : [Attachment 331312] Try to fix Windows builds
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jan 16 16:53:38 PST 2018
Tim Horton <thorton at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 181637: Add injected bundle SPI to replace subresource URLs when dropping
or pasting rich content
https://bugs.webkit.org/show_bug.cgi?id=181637
Attachment 331312: Try to fix Windows builds
https://bugs.webkit.org/attachment.cgi?id=331312&action=review
--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 331312
--> https://bugs.webkit.org/attachment.cgi?id=331312
Try to fix Windows builds
View in context: https://bugs.webkit.org/attachment.cgi?id=331312&action=review
> Source/WebCore/editing/cocoa/WebContentReaderCocoa.mm:293
> + HashMap<AtomicString, AtomicString> subresourceURLToClientURLMap;
Don’t see the need for AtomicString?
> Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePageEditorClient.h:110
> + WKBundlePageReplacementURLForResource
replacementURLForResource;
This is a big no-no. You need to make a new version and append this to the
bottom.
More information about the webkit-reviews
mailing list