[webkit-reviews] review denied: [Bug 181699] Ensure computed style and performance.now are (mostly) in sync : [Attachment 331415] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Dean Jackson <dino at apple.com>'s
request for review:
Bug 181699: Ensure computed style and performance.now are (mostly) in sync
https://bugs.webkit.org/show_bug.cgi?id=181699

Attachment 331415: Patch

https://bugs.webkit.org/attachment.cgi?id=331415&action=review




--- Comment #5 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 331415
  --> https://bugs.webkit.org/attachment.cgi?id=331415
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=331415&action=review

>>> Source/WTF/wtf/MonotonicTime.cpp:47
>>> +
>> 
>> I think this should share code with Performance::reduceTimeResolution().
Either have CSSAnimationControllerPrivate::beginAnimationUpdateTime() call some
Performance thing, or have Performance::reduceTimeResolution call this.
> 
> I considered this (and in fact, I think we'd want
document->domWindow()->nowTimestamp() rather than going through performance).
> 
> However, CSSAnimationController doesn't have a reference to the document, or
the window, and I didn't want to add one. I also expect that there will be
other places where we want a rounded MonotonicTime.

This won't work because in the future, we'd like to restore the resolution for
performance.now,
and doing so would require having access to some objects like Performance or
Document.