[webkit-reviews] review granted: [Bug 181628] Web Inspector: Make Console's Execution Context picker stand out when it is non-default : [Attachment 331275] [PATCH] Proposed Fix
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jan 16 12:36:58 PST 2018
Matt Baker <mattbaker at apple.com> has granted review:
Bug 181628: Web Inspector: Make Console's Execution Context picker stand out
when it is non-default
https://bugs.webkit.org/show_bug.cgi?id=181628
Attachment 331275: [PATCH] Proposed Fix
https://bugs.webkit.org/attachment.cgi?id=331275&action=review
--- Comment #8 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 331275
--> https://bugs.webkit.org/attachment.cgi?id=331275
[PATCH] Proposed Fix
View in context: https://bugs.webkit.org/attachment.cgi?id=331275&action=review
r=me
>>> Source/WebInspectorUI/UserInterface/Views/QuickConsole.css:102
>>> + color: white;
>>
>> Should we use `color: var(--selected-foreground-color);` since it's used for
the arrows?
>
> Err, you're correct. And I do that down below. I think this line can be
removed.
Good catch!
More information about the webkit-reviews
mailing list