[webkit-reviews] review denied: [Bug 181664] [CMake] Remove WebCoreDerivedSources library target : [Attachment 331377] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has denied  review:
Bug 181664: [CMake] Remove WebCoreDerivedSources library target
https://bugs.webkit.org/show_bug.cgi?id=181664

Attachment 331377: Patch

https://bugs.webkit.org/attachment.cgi?id=331377&action=review




--- Comment #7 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 331377
  --> https://bugs.webkit.org/attachment.cgi?id=331377
Patch

(In reply to Fujii Hironori from comment #3)
> I have confirmed CMake Ninja can build with this patch.
Have you confirmed that CMake Ninja can build with this patch on Mac?  This
change was done because linking WebCore on Mac with Ninja exceeded the command
line character limit of something.  Ninja on Linux and Windows worked fine
without this patch, so verifying on those systems is not enough.