[webkit-reviews] review granted: [Bug 181685] Allow dangerous disabling of poison : [Attachment 331392] patch

[bugzilla-daemon at webkit.org]

Keith Miller <keith_miller at apple.com> has granted JF Bastien
<jfbastien at apple.com>'s request for review:
Bug 181685: Allow dangerous disabling of poison
https://bugs.webkit.org/show_bug.cgi?id=181685

Attachment 331392: patch

https://bugs.webkit.org/attachment.cgi?id=331392&action=review




--- Comment #3 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 331392
  --> https://bugs.webkit.org/attachment.cgi?id=331392
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=331392&action=review

r=me.

> Source/JavaScriptCore/ChangeLog:3
> +	   Allow dangerous disabling of poison

I like to live my life on the edge...

> Source/JavaScriptCore/runtime/Options.h:490
> +    v(bool, dangerousDisablePoison, false, Normal, "if true, all poison will
be initialized to 0 which defeats some Spectre and type confusion mitigations,
but allows tools such as leak detectors to function better.") \

Nit: Can we put this by the other Spectre flags? Or move the other flags into
their own section.